allow passing path as input opt #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pushed a commit that makes the test simpler, should pass all tests and operating systems in Travis. |
mixmix
approved these changes
Jan 7, 2021
| @@ -47,7 +47,8 @@ By default, CreateTestSbot deletes an existing database of the same `name` befor | |||
|
|
|||
| Valid `opts` keys include: | |||
| - `name` *String* (optional) (default: `ssb-test + Number(new Date)`) | |||
| - `myTestName`: Sets the database in /tmp/myTestName | |||
| - `path` *String* (optional) (default: `/tmp/${name}`, where `name` is the above) | |||
| - `~/.ssb-test`: Sets the database in `~/.ssb-test` | |||
There was a problem hiding this comment.
This sets the working location for the identity - log databases, secret, conn.json etc
Wonder if there's an easy word for that.
Anyway not a big deal
arj03
approved these changes
Jan 7, 2021
|
Nice, can has merge? |
|
Checked the travis error, seems to have been failing before as well. |
|
Published as 1.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: ssbc/ssb-fixtures#2
Problem: I have generated an SSB database but I want different authors (different ssb keys objects) in scuttle-testbot to share the same folder. scuttle-testbot currently make the
pathfrom thename, but this forces us to use/tmp/somethingfolders.